Labsy wrote:Hi JDunphy,
that's one huge code rewrite, really love it how you incorporated all changes. And love it being organized

BUT there's still work to do - I noticed results are buggy/different, if I switch the order of log parsing
elsif's for "http" and "qtp". Results are much different and it looks like WEB and SMTP parsers rule out each other:
This is one area where I will need your help. I wasn't able to verify your qtp section. When I generated a MUA authentication error it didn't appear in my 8.7+ audit.logs. The only place I could find it was in /var/log/maillog. Could you provide me with the output of:
Code: Select all
% zcat -f /opt/zimbra/log/audit.log* |grep -i invalid | grep qtp
so I could observe that line we are parsing. My guess is that we probably need to pay a little more attention than simply saying anything with http and invalid or qtp and invalid. Should be an easy fix.
I know in my logs, simply asking for qtp will not work because I have lines like this...
Code: Select all
2018-11-04 19:12:39,934 WARN [qtp2036958521-453494:http://localhost:8080 ...
Which belong to the web interface and not part of smtp authentication. I suppose we could always do something like this:
((m#http#) && (#zclient#)) for the http section... or require 'soap' or 'failed', etc. Without knowing what the qtp line we are pattern matching against, I hesitate to recommend a fix. Certainly with my logs, it would yield incorrect results to place qtp in front of http in the parsing order.
Thanks
Jim